Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for GAC #56

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Add unit tests for GAC #56

merged 3 commits into from
Sep 12, 2023

Conversation

Dominator008
Copy link
Collaborator

Part of #45.

ermyas
ermyas reviewed Sep 8, 2023
View reviewed changes
test/unit-tests/GAC.t.sol Outdated Show resolved Hide resolved
test/unit-tests/GAC.t.sol Show resolved Hide resolved
sujithsomraaj
sujithsomraaj approved these changes Sep 11, 2023
View reviewed changes
Copy link
Collaborator

@sujithsomraaj sujithsomraaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except ermyas comments

@ermyas ermyas merged commit 7e25a04 into main Sep 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ermyas ermyas ermyas left review comments

@sujithsomraaj sujithsomraaj sujithsomraaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dominator008 @ermyas @sujithsomraaj